Skip to content

[IMP] Introduce platform gating for existing PR detection#89

Merged
sebalix merged 1 commit intoOCA:mainfrom
dzungtran89:imp-option-detect-existing-pr
Jan 28, 2026
Merged

[IMP] Introduce platform gating for existing PR detection#89
sebalix merged 1 commit intoOCA:mainfrom
dzungtran89:imp-option-detect-existing-pr

Conversation

@dzungtran89
Copy link
Copy Markdown
Contributor

@dzungtran89 dzungtran89 commented Oct 24, 2025 •
edited
Loading

Rationale

Only attempt to detect existing Pull Requests on currently supported
platforms (i.e., 'github').

@dzungtran89
Copy link
Copy Markdown
Contributor Author

dzungtran89 commented Oct 24, 2025

FYI, regarding the failed test, I could not reproduce the issue locally.

========================================= test session starts =========================================
platform linux -- Python 3.11.14, pytest-8.4.2, pluggy-1.6.0 -- /home/dzungt/.local/share/virtualenvs/oca-311/bin/python
cachedir: .pytest_cache
rootdir: /home/dzungt/code/github/oca-port
configfile: pyproject.toml
collected 41 items                                                                                    
...

oca_port/tests/test_utils_git.py::TestGit::test_different_commit_eq PASSED                      [ 70%]
oca_port/tests/test_utils_git.py::TestGit::test_different_commit_eq_paths PASSED                [ 73%]

sebalix
sebalix reviewed Nov 24, 2025
View reviewed changes
Comment thread oca_port/migrate_addon.py Outdated
@dzungtran89 dzungtran89 force-pushed the imp-option-detect-existing-pr branch from 46c408d to 06c807a Compare November 25, 2025 04:20
@dzungtran89 dzungtran89 changed the title [IMP] Allow to not detect existing PRs before porting [IMP] Introduce platform gating for existing PR detection Nov 25, 2025
sebalix
sebalix reviewed Nov 25, 2025
View reviewed changes
Comment thread oca_port/migrate_addon.py Outdated
@dzungtran89
[IMP] Introduce platform gating for existing PR detection
5fb7117 
Only attempt to detect existing Pull Requests on currently supported
platforms (i.e., 'github').
@dzungtran89 dzungtran89 force-pushed the imp-option-detect-existing-pr branch from 06c807a to 5fb7117 Compare November 25, 2025 09:09
@sebalix sebalix merged commit 666965a into OCA:main Jan 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebalix sebalix sebalix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dzungtran89 @sebalix